Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discover card and add unionPay #305

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix discover card and add unionPay #305

merged 1 commit into from
Nov 18, 2024

Conversation

AnasNaouchi
Copy link
Contributor

Description

  • Test cards for unionPay and discover were not usable in the SDK.
  • Edited max card length to 19 for both types.
  • Added required assets.
  • Changed auto formatting for all cards to auto split every 4 chars.

FhanOmise
FhanOmise previously approved these changes Nov 14, 2024
Narum11
Narum11 previously approved these changes Nov 15, 2024
aashishgurung
aashishgurung previously approved these changes Nov 15, 2024
@AnasNaouchi AnasNaouchi changed the base branch from master to develop November 18, 2024 04:50
@AnasNaouchi AnasNaouchi dismissed stale reviews from aashishgurung, Narum11, and FhanOmise November 18, 2024 04:50

The base branch was changed.

@AnasNaouchi AnasNaouchi merged commit dd6c956 into develop Nov 18, 2024
1 of 3 checks passed
@AnasNaouchi AnasNaouchi deleted the fix_test_cards branch November 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants